Skip to content

Note about @InternedDistinct and constructor results#7635

Open
mernst wants to merge 1 commit intotypetools:masterfrom
mernst:new-not-interned-distinct
Open

Note about @InternedDistinct and constructor results#7635
mernst wants to merge 1 commit intotypetools:masterfrom
mernst:new-not-interned-distinct

Conversation

@mernst
Copy link
Copy Markdown
Member

@mernst mernst commented Apr 10, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 7f0bda1a-7717-49bd-ae96-30b52350efe6

📥 Commits

Reviewing files that changed from the base of the PR and between 726738e and f139518.

📒 Files selected for processing (1)
  • docs/manual/interning-checker.tex

📝 Walkthrough

Walkthrough

This change adds a clarifying statement to the documentation for the @InternedDistinct annotation. Specifically, it explains that a constructor call result (e.g., new MyClass(...)) is not necessarily @InternedDistinct, because the equals() method of MyClass may consider two distinct objects equal. The modification is documentation-only and affects approximately four lines in the interning-checker documentation file.

Possibly related PRs

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants